-
Notifications
You must be signed in to change notification settings - Fork 966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
avoid argument warnings / prepare for ruby 3 #1209
Conversation
5ca7f8a
to
2143bb2
Compare
In order to go forward, I resolved the conflict in favor of the merged PR #1211. Hehe, now codeclimate wants there to be be fewer arguments, of course, of course. |
thx, there are some real bugs in here, (ran tests on 2.4 / 2.7 and no combination made both work) |
I made a bad lostisland#1211 merge. This tries to repair that.
@grosser Now I'm just messing with this, perhaps we can take a smaller step forwards trying to find working code. Grr, now I made a commit which predictably works on 2.7, but now the others. As you say, perhaps keeping the ruby2_keywords gem to support Olde Versions. In addition, I noted that the coveralls gem is old and wonky, and I think I recall someone's actually shepherding it in a GitHub repo, somewhere. So, one could use that gem, to avoid red output at the end of the test run. |
Could also try https://github.com/grosser/single_cov :D |
We support Ruby 3.0, 3.1 and 3.2 pretty well now so this should not be necessary anymore 👍 |
builds on top of #1208
reverts #1153 since 2.7 no longer has warnings and 3.0 works